Remove deprecations for 26.10 dev cycle - #8435
Merged
Merged
Conversation
jcrist
added
improvement
4 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change removes the Porter stemmer implementation and exports, removes the experimental ChangesAPI and metric cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/cuml/cuml/metrics/pairwise_distances.pyx`:
- Around line 336-339: Update the keyword validation in the Minkowski branch of
pairwise distance handling: pop the supported p argument first, then reject any
remaining kwds with the existing TypeError path so metric_arg and other unknown
keywords are not ignored. Add a regression case in test_metrics.py confirming
metric="minkowski" with metric_arg raises TypeError.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8994925e-fe87-42c7-9862-59d32a969dff
📒 Files selected for processing (20)
docs/source/api/cuml.preprocessing.rstpython/cuml/cuml/experimental/linear_model/__init__.pypython/cuml/cuml/metrics/pairwise_distances.pyxpython/cuml/cuml/preprocessing/__init__.pypython/cuml/cuml/preprocessing/text/__init__.pypython/cuml/cuml/preprocessing/text/stem/__init__.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/__init__.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/consonant_vowel_utils.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/len_flags_utils.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/measure_utils.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/porter_stemmer_rules.pypython/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/suffix_utils.pypython/cuml/tests/stemmer_tests/test_len_utils.pypython/cuml/tests/stemmer_tests/test_porter_stemmer_rules.pypython/cuml/tests/stemmer_tests/test_stemmer.pypython/cuml/tests/stemmer_tests/test_steps.pypython/cuml/tests/stemmer_tests/test_suffix_utils.pypython/cuml/tests/test_lars.pypython/cuml/tests/test_metrics.py
💤 Files with no reviewable changes (16)
- python/cuml/cuml/preprocessing/text/init.py
- python/cuml/cuml/experimental/linear_model/init.py
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/init.py
- python/cuml/cuml/preprocessing/text/stem/init.py
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/consonant_vowel_utils.py
- docs/source/api/cuml.preprocessing.rst
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer.py
- python/cuml/tests/stemmer_tests/test_len_utils.py
- python/cuml/tests/stemmer_tests/test_suffix_utils.py
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/len_flags_utils.py
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/measure_utils.py
- python/cuml/tests/stemmer_tests/test_steps.py
- python/cuml/tests/stemmer_tests/test_porter_stemmer_rules.py
- python/cuml/tests/stemmer_tests/test_stemmer.py
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/suffix_utils.py
- python/cuml/cuml/preprocessing/text/stem/porter_stemmer_utils/porter_stemmer_rules.py
jcrist
force-pushed
the
remove-deprecations-2610
branch
from
August 3, 2026 16:46
9688f2a to
2d688b9
Compare
csadorf
approved these changes
Aug 3, 2026
rapids-bot Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
This removes support for the following deprecated `output_type` values: - `"numba"` - `"dataframe"` - `"series"` - `"df_obj"` - `"array"` The latter 4 are all aliases for other concrete types (e.g. `"array"` is the same as `"cupy"`). For `"numba"`, `cuml` now treats numba inputs the same as any other non-cupy input type that implements `__cuda_array_interface__` (coerces to `cupy`, and returns cupy outputs by default). This code path is still tested in the generic estimator input/output types, but in most other places where `numba` was explicitly part of the parametrized tests we've opted to simplify to remove that branch as duplicative of `cupy` inputs. This also removes the deprecated `sparse_pairwise_distances` function. This should have been handled in #8435, but was accidentally missed. This is the only remaining deprecation in need of removal for 26.10 - I'm including it here to avoid another PR. Part of #8225. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #8439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a few deprecated features that can be removed in the 26.10 development cycle:
cuml.experimental.linear_modelnamespacecuml.preprocessing.textnamespacemetric_argtopairwise_distancesPart of #8225.